@thrasher- I've pulled in the abstracted form of testExch.TestInstance which was prototyped in #1358 and then built out for other exchanges.
That's allowed us to isolate the kucoin sub testing from the pair changes introduced for GetOpenInterest testing.

Also rebased to fix the master conflict.

Codecov Report

Attention: 342 lines in your changes are missing coverage. Please review.

Comparison is base (301551a) 43.33% compared to head (0e4eac8) 43.39%.

❗ Current head 0e4eac8 differs from pull request most recent head 44f7c91. Consider uploading reports for the commit 44f7c91 to get more accurate results

@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
+ Coverage   43.33%   43.39%   +0.06%     
==========================================
  Files         366      367       +1     
  Lines      147087   147096       +9     
==========================================
+ Hits        63744    63837      +93     
+ Misses      75520    75436      -84     
  Partials     7823     7823              

🔁 Rebased on master

I have found myself confused about how your rebasing timelines work. I requested changes on Jan 2nd, but there is only changes done on November 22nd and Jan 16 which was after I approved my review on January 8th.

So do change requests get bundled before or after? It is more difficult to keep track of all pull request reviews and their state of code leaving me doubting what code specifically I had already reviewed. I'll do a final review tomorrow

Rebased after you approved and added gcrc. At that point all changes you'd asked for and subsequently approved get fixuped down to their respective original commits.

Then any commits added after that are left for you to see again.

Specifically the code you haven't reviewed was 94da21f and 7283b51.

edit: Shazbert's request here: #1394 (comment) got pulled into a commit from 2 months ago, yet it was raised on January 8th, meaning I can't really trust the commit from November 22nd since it has changed since I reviewed it

Yes. The commit was fixed on 8th January and merged down on 15th January ( specifically after you signalled you were done ).

The commits change, but the body of code is as you last saw it. The autosquash just moves the commits down and merges them once you've approved your changes.

As discussed previously, I'm leaving everything completely alone until each member is done, and then I merge it at that point.

Since it seems confusing, I can leave it right until the end and then rebase at the very last moment?
Normally fixups get merged when you rebase on master, but I can avoid that.

Thank you for your explanations. I can put my reply which I messaged you here if you'd like. I re-reviewed everything and only found the tiniest thing 😄

Thank you 🙏 Ready again.